Skip to content

ref: Convert ExtraContextProvider to Swift #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

ref: Convert ExtraContextProvider to Swift #6445

merged 1 commit into from
Oct 17, 2025

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 17, 2025 •
edited by github-actions bot
Loading

Straightforward objc to Swift conversion

#skip-changelog

Closes #6446

@github-actions github-actions bot mentioned this pull request Oct 17, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4021 1 4020 28
View the top 2 failed test(s) by shortest run time 
SentryTests.SentryANRTrackerV1Tests::testMultipleANRs_MultipleReported
Stack Traces | 0s run time 
.../Integrations/ANR/SentryANRTrackerV1Tests.swift:128 - Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "ANR Detection", "ANR Stopped".
iOS_SwiftUI_UITests.LaunchUITests::testCaptureErrorReturnsValidId
Stack Traces | 0s run time 
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:91 - Failed to terminate io.sentry.iOS-SwiftUI:11872: Failed to terminate io.sentry.iOS-SwiftUI:0

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@noahsmartin noahsmartin force-pushed the extraContextProviderSwift branch from 9e830b8 to f158c42 Compare October 17, 2025 02:52
seer-by-sentry[bot]
seer-by-sentry bot reviewed Oct 17, 2025
View reviewed changes
@noahsmartin noahsmartin force-pushed the extraContextProviderSwift branch 3 times, most recently from 4ff0fe6 to d892f23 Compare October 17, 2025 02:59
cursor[bot]

This comment was marked as outdated.

Sign in to view

@noahsmartin noahsmartin force-pushed the extraContextProviderSwift branch 2 times, most recently from a355868 to c89402d Compare October 17, 2025 03:12
cursor[bot]

This comment was marked as outdated.

Sign in to view

@noahsmartin noahsmartin force-pushed the extraContextProviderSwift branch from c89402d to b7e868a Compare October 17, 2025 03:18
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.77 ms 1246.17 ms 31.40 ms
Size 23.75 KiB 1015.29 KiB 991.54 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
67e8e3e 1238.80 ms 1266.02 ms 27.22 ms
9cbff30 1236.33 ms 1254.35 ms 18.03 ms
4b3f1af 1227.04 ms 1253.35 ms 26.31 ms
2a07609 1207.79 ms 1233.77 ms 25.98 ms
5ec90e0 1235.57 ms 1258.45 ms 22.88 ms
7fc6927 1221.21 ms 1242.36 ms 21.15 ms
5196f0d 1213.35 ms 1231.37 ms 18.02 ms
d23a1b1 1218.94 ms 1239.53 ms 20.60 ms
035974f 1225.89 ms 1251.23 ms 25.34 ms
7b3399c 1193.35 ms 1227.38 ms 34.03 ms

App size

Revision Plain With Sentry Diff
67e8e3e 23.75 KiB 919.88 KiB 896.13 KiB
9cbff30 23.75 KiB 928.15 KiB 904.40 KiB
4b3f1af 23.75 KiB 981.30 KiB 957.56 KiB
2a07609 23.75 KiB 912.78 KiB 889.03 KiB
5ec90e0 23.74 KiB 872.67 KiB 848.92 KiB
7fc6927 23.75 KiB 908.54 KiB 884.79 KiB
5196f0d 23.75 KiB 876.93 KiB 853.19 KiB
d23a1b1 23.75 KiB 913.64 KiB 889.88 KiB
035974f 23.74 KiB 874.07 KiB 850.33 KiB
7b3399c 23.75 KiB 946.68 KiB 922.94 KiB

Previous results on branch: extraContextProviderSwift

Startup times

Revision Plain With Sentry Diff
31f005b 1192.31 ms 1258.11 ms 65.79 ms

App size

Revision Plain With Sentry Diff
31f005b 23.75 KiB 1015.23 KiB 991.49 KiB

philipphofmann
philipphofmann approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @noahsmartin

@noahsmartin noahsmartin force-pushed the extraContextProviderSwift branch from b7e868a to 8d46aa9 Compare October 17, 2025 13:59
@noahsmartin noahsmartin merged commit dad3d69 into main Oct 17, 2025
194 of 205 checks passed
@noahsmartin noahsmartin deleted the extraContextProviderSwift branch October 17, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@philipphofmann philipphofmann philipphofmann approved these changes

@philprime philprime Awaiting requested review from philprime philprime is a code owner

@itaybre itaybre Awaiting requested review from itaybre itaybre is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ref: Convert ExtraContextProvider to Swift

2 participants

@noahsmartin @philipphofmann